chihsuan commented on code in PR #11108:
URL: https://github.com/apache/ozone/pull/11108#discussion_r3885234017
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java:
##########
@@ -153,6 +156,10 @@ public void initialize(URI name, Configuration conf)
throws IOException {
throw new IllegalArgumentException(URI_EXCEPTION_TEXT);
}
+ if (authority.indexOf(':') != authority.lastIndexOf(':')) {
Review Comment:
Thanks for the fix here. I noticed the OFS side still classifies any
multi-colon authority as IPv6, so `ofs://host:123:456/` gets the bracket
message. Would `InetAddresses.isInetAddress` work there too?
https://github.com/apache/ozone/blob/22217a51ed214848d6963896a9bcc82edc2ec98f/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java#L167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
