rjgoyln commented on PR #11130: URL: https://github.com/apache/ozone/pull/11130#issuecomment-5460647606
> Thanks for the patch! @rjgoyln Overall, looks good. > > I left a few inline notes, mostly around test coverage for the URI path. > > Also a heads-up: #11108 makes the identical `OmUtils` change, so whichever lands first will make the other's diff vanish. cc @echonesis Thanks for the heads-up on #11108! I just checked the diffs. The OmUtils.java changes are completely identical, and our test additions in TestOmUtils.java are in completely different locations. I’ll keep this PR self-contained for now. If #11108 lands first, I’ll rebase and clean up the redundant changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
