ivandika3 commented on code in PR #11158:
URL: https://github.com/apache/ozone/pull/11158#discussion_r3889374247
##########
hadoop-ozone/mini-cluster/src/main/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java:
##########
@@ -622,11 +623,11 @@ protected void initializeConfiguration() throws
IOException {
}
private void configureHostAndRackTopology() throws IOException {
- FixedHostMapping.clear();
if (racks == null && hosts == null) {
return;
}
+ StaticMapping.resetMap();
Review Comment:
> For example, TestStorageContainerManager [configures StaticMapping
directly](https://github.com/F64116045/ozone/blob/8b95f2d1052416d0d0d1289b142493ca01d3b237/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestStorageContainerManager.java#L646-L654)
and then [builds the cluster without calling setRacks() or
setHosts()](https://github.com/F64116045/ozone/blob/8b95f2d1052416d0d0d1289b142493ca01d3b237/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestStorageContainerManager.java#L169-L177).
Thanks for checking this, I think `TestStorageContainerManager`
`configureTopology` can be moved to MiniOzoneCluster `setRacks` and `setHosts`?
How about we address it here?
> added an assertion to verify that the map is empty after cluster shutdown.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
