sravani-revuri commented on code in PR #11132:
URL: https://github.com/apache/ozone/pull/11132#discussion_r3891734900
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -816,9 +816,9 @@ private String reconfigScmNodes(String value) {
}
// Add the new SCM servers
- for (Pair<String, HostAndPort> pair : scmToAdd) {
- String scmNodeId = pair.getLeft();
- final HostAndPort scmAddress = pair.getRight();
+ for (ScmNodeAddress entry : scmToAdd) {
Review Comment:
nit: when this was a Pair, the variable being named pair made sense because
the type carried the meaning. Now that it's ScmNodeAddress, would it read
better to rename entry to something more descriptive like scmEndpoint or
nodeAddress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
