shuan1026 opened a new pull request, #11193:
URL: https://github.com/apache/ozone/pull/11193

   ## What changes were proposed in this pull request?
   
   Datanode `BlockDeletingService` starts from 
`hdds.datanode.block.deleting.service.interval`, but `updateAndRestart` reread 
`ozone.block.deleting.service.interval` (OM's key). HDDS-11513 wired the 
reconfig path to the shared key after HDDS-4367 had split them. Details are on 
the Jira.
   
   This patch uses the datanode-specific key on every path:
   
   - Mark `hdds.datanode.block.deleting.service.interval` as `reconfigurable = 
true` and register it via `register(dnConf)`.
   - `updateAndRestart` reads 
`DatanodeConfiguration.getBlockDeletionInterval()` in milliseconds, same as 
startup.
   - Remove the DataNode registration of 
`ozone.block.deleting.service.interval`. Timeout / workers and OM's shared key 
are unchanged.
   - `Reconfigurability.md` is updated to match the change.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-16374
   
   ## How was this patch tested?
   
   - `TestBlockDeletingService` (including new 
`testUpdateAndRestartUsesDatanodeInterval`): pass. Restoring the old key read 
fails with `expected: <300000> but was: <60000>`.
   - ci: https://github.com/shuan1026/ozone/actions/runs/33639637827


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to