F64116045 commented on code in PR #11199:
URL: https://github.com/apache/ozone/pull/11199#discussion_r3937052231
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ReconReplicationManager.java:
##########
@@ -313,8 +279,11 @@ public synchronized void processAll() {
// readOnly=true ensures no commands are generated
processContainer(container, replicas, pendingOps, nullQueue, report,
true);
- // ADDITIONAL CHECK: Detect REPLICA_MISMATCH (Recon-specific, not in
SCM)
- if (hasDataChecksumMismatch(replicas)) {
+ // Persist checksum mismatches in Recon's REPLICA_MISMATCH state.
+ if (container.getState() == CLOSED &&
+ container.getReplicationType() == RATIS &&
+ hasMismatch(replicas, ContainerReplica::getSequenceId,
Review Comment:
Recon still reports a mismatch immediately, as it did before. It does not
use SCM’s two-scan debounce. This preserves Recon’s existing reporting
behavior, but means Recon may report the mismatch before SCM confirms it and
before the CLI displays it.
Please let me know if you have any concerns about keeping this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
