arunsarin85 commented on PR #10726: URL: https://github.com/apache/ozone/pull/10726#issuecomment-5556762666
Hi @SaketaChalamchala @jojochuang I've addressed all the review comments in a follow-up PR: https://github.com/apache/ozone/pull/11212 Changes made on top of this patch: - Moved `waitForSnapshotsPurged` and `dirDeletingService.resume()` from the test body into `@AfterEach cleanup()` using instance tracking fields (`snapshotCountAfterTest`, `pendingResumeDds`, `needsTableCleanup`), so services are always resumed and snapshots always purged even when a test fails mid-way. - Moved `waitForSnapshotsPurged` and `cleanupTables()` from `testDirDeletedTableCleanUpForSnapshot` to `@AfterEach cleanup()` in the same way. - Removed the redundant `cluster.getOzoneManager().awaitDoubleBufferFlush()` before `waitForSnapshotsPurged` in `testDirDeletedTableCleanUpForSnapshot`. - Fixed mis-indented try/catch braces inside the `waitForSnapshotsPurged` lambda (checkstyle). - Removed the redundant `assertTableRowCount` call after `waitFor` in `waitForSnapshotsPurged` - `waitFor` already guarantees the condition before returning. Flaky Test run after the fix : https://github.com/arunsarin85/ozone/actions/runs/33992835360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
