sreejasahithi commented on code in PR #11037:
URL: https://github.com/apache/ozone/pull/11037#discussion_r3986230699
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerClusterAnalyzer.java:
##########
Review Comment:
Thanks @sravani-revuri for the updates.
1. In future when we add an assessment command say `ozone admin
containerbalancer assessment`
and expect an output as below , but ContainerBalancerClusterSnapshot
currently exposes only hostnames for top/bottom nodes, we wont be able to
display the utilization of each and their deviation from avg. Those values are
computed inside ContainerBalancerClusterAnalyzer in private NodeClassification
objects and then skipped when building the snapshot.
```
CLUSTER BALANCE ASSESSMENT
═══════════════════════════════════════════════════════════════════════
Drift: 23.5% (max utilization 91.2% − min utilization 67.7%)
Mean Utilization: 78.4%
Cluster Size: 120 datanodes (118 healthy, 2 stale)
Category: Large cluster, High imbalance, Medium movement ratio
─── Source Nodes (over-utilized) ─────────────────────────────────────
14 datanodes above threshold
Top 5:
dn-worker-017.example.com 91.2% (+13.2% above mean)
dn-worker-004.example.com 89.8% (+11.4% above mean)
dn-worker-022.example.com 88.1% (+9.7% above mean)
dn-worker-011.example.com 87.6% (+9.2% above mean)
dn-worker-039.example.com 86.9% (+8.5% above mean)
─── Target Nodes (under-utilized) ────────────────────────────────────
11 datanodes below threshold
Bottom 5:
dn-worker-118.example.com 67.7% (−10.7% below mean)
dn-worker-119.example.com 68.2% (−10.2% below mean)
dn-worker-120.example.com 69.1% (−9.3% below mean)
dn-worker-115.example.com 70.4% (−8.0% below mean)
dn-worker-116.example.com 71.0% (−7.4% below mean)
─── Movement Summary ─────────────────────────────────────────────────
Total bytes to move: 420 TB
Movement ratio: 3.4% of cluster capacity
```
2. TOP_NODE_LIMIT = 5 is hardcoded, fine for now, but assessment CLI may
want this configurable later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
