taklwu commented on code in PR #11102:
URL: https://github.com/apache/ozone/pull/11102#discussion_r3987018569
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/LocalChunkInputStream.java:
##########
@@ -72,6 +74,22 @@ public class LocalChunkInputStream extends ChunkInputStream
}
}
+ /**
+ * LocalChunkInputStream reads from a local FileChannel; no xceiver client
is needed.
+ */
+ @Override
+ protected synchronized XceiverClientSpi acquireClient() {
+ return null;
+ }
Review Comment:
need this after HDDS-16100 #11117 merged
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/LocalChunkInputStream.java:
##########
@@ -72,6 +74,22 @@ public class LocalChunkInputStream extends ChunkInputStream
}
}
+ /**
+ * LocalChunkInputStream reads from a local FileChannel; no xceiver client
is needed.
+ */
+ @Override
+ protected synchronized XceiverClientSpi acquireClient() {
+ return null;
+ }
+
+ /**
+ * Local reads do not use an xceiver client; delegate to the one-arg
override.
+ */
+ @Override
+ protected ByteBuffer[] readChunk(ChunkInfo readChunkInfo, XceiverClientSpi
client) throws IOException {
+ return readChunk(readChunkInfo);
+ }
Review Comment:
this is needed otherwise the datanodeBlockID is emitting NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
