ss77892 commented on code in PR #11233:
URL: https://github.com/apache/ozone/pull/11233#discussion_r3997346490
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/db/Proto2Codec.java:
##########
@@ -89,13 +87,12 @@ public String toString() {
@Override
public M fromCodecBuffer(@Nonnull CodecBuffer buffer)
throws CodecException {
- final InputStream in = buffer.getInputStream();
+ // Parse the buffer directly, as Proto3Codec does: parsing through an
InputStream makes protobuf
+ // allocate a 4 KB decoding buffer per call, on values which are typically
a few hundred bytes.
Review Comment:
Thank you for looking into it @chihsuan . I've removed the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
