Gargi-jais11 commented on code in PR #11229:
URL: https://github.com/apache/ozone/pull/11229#discussion_r4011900485
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3Consts.java:
##########
@@ -131,6 +131,11 @@ public final class S3Consts {
/** Request header carrying the list of object attributes to return. */
public static final String OBJECT_ATTRIBUTES_HEADER =
"x-amz-object-attributes";
+ // S3 storage class values passed via the `x-amz-storage-class` request
header.
+ public static final String S3_STORAGE_CLASS_STANDARD = "STANDARD";
+ public static final String S3_STORAGE_CLASS_STANDARD_IA = "STANDARD_IA";
+ public static final String S3_STORAGE_CLASS_GLACIER = "GLACIER";
+
Review Comment:
I don't know whether u are aware or not but `S3StorageType.java` in the S3
Gateway has similar enums means: “this S3 storage class string picks how many
copies / EC layout the object gets” (STANDARD → 3-way Ratis, STANDARD_IA → EC,
etc.). Almost all upload/download code uses that today.
This PR adds S3StorageClass, which means: “this string picks Hot / Warm /
Cold (which disk tier).”
Those are two different ideas with similar names. That will confuse people
and cause wrong imports later.
We should look into these and check how they both can be used independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
