navinko commented on code in PR #10830: URL: https://github.com/apache/ozone/pull/10830#discussion_r4041152978
########## hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockOutputStreamEntryPool.java: ########## Review Comment: Thanks @smengcl for the review , suggestions incorporated! Added unit test- testGetCurrentStreamEntryDuringBlockAllocation Successful CI : https://github.com/navinko/ozone/actions/runs/35261148392 - Without fix, test case fails `org.opentest4j.AssertionFailedError: Reader must not observe the intermediate index before the new entry is added ==> Expected :BlockOutputStreamEntry:k conID: 1 locID: 2 bcsId: 0 replicaIndex: null Actual :null` - With Fix, test case succeed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
