Russole commented on code in PR #10837:
URL: https://github.com/apache/ozone/pull/10837#discussion_r4051811546
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java:
##########
@@ -771,16 +776,17 @@ public void testSetNodeOpStateAndCommandFired()
*/
@Test
public void testScmDetectStaleAndDeadNode()
- throws IOException, InterruptedException, AuthenticationException {
+ throws IOException, InterruptedException, AuthenticationException,
+ TimeoutException {
final int interval = 100;
final int nodeCount = 10;
OzoneConfiguration conf = getConf();
conf.setTimeDuration(OZONE_SCM_HEARTBEAT_PROCESS_INTERVAL, interval,
MILLISECONDS);
- conf.setTimeDuration(HDDS_HEARTBEAT_INTERVAL, 1, SECONDS);
- conf.setTimeDuration(OZONE_SCM_STALENODE_INTERVAL, 3, SECONDS);
- conf.setTimeDuration(OZONE_SCM_DEADNODE_INTERVAL, 6, SECONDS);
+ conf.setTimeDuration(HDDS_HEARTBEAT_INTERVAL, interval, MILLISECONDS);
+ conf.setTimeDuration(OZONE_SCM_STALENODE_INTERVAL, 300, MILLISECONDS);
+ conf.setTimeDuration(OZONE_SCM_DEADNODE_INTERVAL, 600, MILLISECONDS);
Review Comment:
These configured values are not used as-is. When running
`testScmDetectStaleAndDeadNode`, the logs show:
```text
ozone.scm.stale.node.interval value = 300 is smaller than min = 500 based on
the key value of ozone.scm.heartbeat.thread.interval, reset to the min value
500.
ozone.scm.dead.node.interval value = 600 is smaller than min = 1000 based on
the key value of ozone.scm.stale.node.interval, reset to the min value 1000.
```
Could we use a separate 50 ms health-check interval while keeping the
heartbeat and polling interval at 100 ms? This would allow the intended 300/600
ms intervals to take effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
