hani-fouladgar commented on code in PR #11295:
URL: https://github.com/apache/ozone/pull/11295#discussion_r4106828232
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestInterSCMGrpcClient.java:
##########
@@ -75,6 +75,37 @@ void testDownloadIsAbortedAtConfiguredDeadline() throws
Exception {
}
}
+ /**
+ * The client channel keepalive settings are additive to the deadline: a
+ * stuck download must still be aborted at the configured deadline when
+ * custom keepalive values are set.
+ */
+ @Test
+ void testDownloadIsAbortedAtDeadlineWithCustomKeepAlive() throws Exception {
Review Comment:
Agreed, the tests weren't actually exercising the keepalive wiring. Fixed
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
