adoroszlai commented on code in PR #11327:
URL: https://github.com/apache/ozone/pull/11327#discussion_r4106934765
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -1042,6 +1043,11 @@ public Map<String, ErrorInfo> deleteKeys(OmDeleteKeys
deleteKeys, boolean quiet)
Map<String, ErrorInfo> keyToErrors = new HashMap<>();
if (quiet) {
+ // PARTIAL_DELETE means the batch was processed and only some keys
failed; those are reported per key
+ // in the returned map. Any other non-OK status means the whole request
failed.
+ if (omResponse.getStatus() != PARTIAL_DELETE) {
+ handleError(omResponse);
+ }
Review Comment:
nit: flow can be simplified a bit
```suggestion
if (quiet && omResponse.getStatus() == PARTIAL_DELETE) {
// PARTIAL_DELETE means the batch was processed and only some keys
failed; those are reported per key
// in the returned map. Any other non-OK status means the whole
request failed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
