priyeshkaratha opened a new pull request, #11344:
URL: https://github.com/apache/ozone/pull/11344

   ## What changes were proposed in this pull request?
   
`OMLifecycleConfigurationSetRequest.validateAbortMpuDaysAgainstCleanupThreshold`
 rejects a lifecycle rule's `AbortIncompleteMultipartUpload` action when its 
`DaysAfterInitiation` is not less than the configured 
`ozone.om.open.mpu.expire.threshold`, since `MultipartUploadCleanupService` 
would otherwise reap the upload before the lifecycle rule ever fires. That 
validation is correct, but the error message's remediation was not actionable: 
it suggested setting `daysAfterInitiation` below a value expressed in the 
threshold's configured unit (e.g. `300s`), while the S3 lifecycle API only 
accepts `DaysAfterInitiation` as a whole number of days.
   
   This PR keeps the same rejection behavior and updates only the message:
   - States that `DaysAfterInitiation` is whole-day granularity and can't be 
expressed directly in the threshold's unit.
   - Computes the largest whole-day value that would threshold and suggests it 
(along with increasing the threshold) when one exists.
   - Falls back to "increase `ozone.om.open.mpu.expire.threshold` to more than 
1 day" when the threshold itself is under a day `DaysAfterInitiation` value 
could satisfy it.
   
   ## What is the link to the Apache JIRA
   
   HDDS-16624
   
   ## How was this patch tested?
   
   Validated manually
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to