jojochuang commented on code in PR #10572:
URL: https://github.com/apache/ozone/pull/10572#discussion_r4116757631
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3ConditionalRequest.java:
##########
@@ -207,7 +207,7 @@ private static Response buildNotModifiedResponse(OzoneKey
key) {
return responseBuilder.build();
}
- private static boolean eTagMatches(String headerValue, String currentETag) {
+ public static boolean eTagMatches(String headerValue, String currentETag) {
Review Comment:
```suggestion
/**
* Checks whether the supplied ETag header value matches the current
object ETag.
* <p>
* The header may contain a comma-separated list of ETags, and the special
* wildcard value {@code *} matches any current ETag.
* </p>
*
* @param headerValue the raw value from the conditional request header
* @param currentETag the current object's ETag
* @return {@code true} if any candidate ETag matches or the wildcard is
present;
* {@code false} otherwise
*/
public static boolean eTagMatches(String headerValue, String currentETag) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
