szetszwo commented on code in PR #11294:
URL: https://github.com/apache/ozone/pull/11294#discussion_r4136502971
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientShortCircuit.java:
##########
@@ -254,63 +264,33 @@ private XceiverClientReply sendCommandWithTraceID(
try {
if (LOG.isDebugEnabled()) {
- LOG.debug("Executing command {} on datanode {}", request, dn);
- }
- reply.addDatanode(dn);
- responseProto =
sendCommandInternal(finalPayload).getResponse().get();
- if (validators != null && !validators.isEmpty()) {
- for (Validator validator : validators) {
- validator.accept(request, responseProto);
- }
+ LOG.debug("Executing {} on {}", processForDebug(request), dn);
}
+ response = sendCommandInternal(finalPayload);
Review Comment:
That's a good point! We should call get inside the span. The code is even
simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
