rich7420 commented on code in PR #11239:
URL: https://github.com/apache/ozone/pull/11239#discussion_r4143673273
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/ContainerProtocolCalls.java:
##########
@@ -197,7 +201,8 @@ public static GetBlockResponseProto
getBlock(XceiverClientSpi xceiverClient,
builder.setEncodedToken(token.encodeToUrlString());
}
- return tryEachDatanode(xceiverClient.getPipeline(),
+ return tryEachDatanode(
+
xceiverClient.getDatanodesInOrder(blockID.getDatanodeBlockIDProtobuf(),
Type.GetBlock),
Review Comment:
For RATIS, this lookup omits `replicaIndex`, but the cached request sets it
to `0`, so the cache misses. With topology-aware reads disabled, my probe shows
the next GetBlock retrying the failed leader instead of using the cached
follower. Please align the cache keys and add a regression test for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
