cchung100m opened a new pull request, #11381:
URL: https://github.com/apache/ozone/pull/11381

   ## What changes were proposed in this pull request?
   
   Several SCM, Recon, and datanode logs print only the datanode 
UUID(`dn.getID()`, `dn.getUuidString()` or a Ratis `RaftPeerId`), although the 
call site already holds a `DatanodeDetails`, `DatanodeInfo` or `RaftPeer`. 
Their `toString()` already includes the host/IP (`uuid(host/ip)`, 
`uuid|address`), so the information is dropped needlessly.
   
   Pass the object itself to the logger instead of its ID. Only log/exception 
message arguments change; no signatures, `toString()` implementations or CLI 
output formats.
   
   Not covered: Ratis-internal logs, and call sites that only have a 
`DatanodeID` (e.g. `SCMDeletedBlockTransactionStatusManager`, 
`XceiverServerRatis#handlePipelineFailure`), which would need signature changes 
or lookups.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-2821
   
   ## How was this patch tested?
   
   Existing unit and integration tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to