jojochuang commented on PR #10759: URL: https://github.com/apache/ozone/pull/10759#issuecomment-5955511469
@kerneltime Thanks for the detailed review. I pushed a follow-up on my fork that addresses both P2 items: https://github.com/jojochuang/ozone/tree/HDDS-15087 (commit 950d4ed11eb) **1. `x-amz-storage-class: STANDARD` on the default one-datanode runtime** Production S3G maps `STANDARD` to Ratis factor three via `S3StorageType`, which bypasses the local `STAND_ALONE/ONE` defaults. I added `ozone.s3g.standard.storage-class.use-client-default` (default `false`). When enabled, an explicit `STANDARD` header uses `ozone.replication` / `ozone.replication.type` instead of the hard-coded Ratis/THREE mapping. `ozone local` turns this on in `configureS3Gateway()` alongside the existing local replication overrides. Regression coverage: `TestLocalOzoneS3#s3GatewayPutGetWithStandardStorageClass` (AWS SDK v2 PUT/GET with `StorageClass.STANDARD`) and `TestS3Utils#testStandardStorageClassUsesClientDefaultWhenEnabled`. **2. `HTTPS_ONLY` advertising a non-listening HTTP endpoint** The runtime already forces `ozone.s3g.http.enabled=true` because the summary reads the bound HTTP port. I also force `ozone.http.policy=HTTP_ONLY` when S3G is enabled, so `BaseHttpServer` cannot leave HTTP disabled while we still print an `http://` endpoint. User `HTTPS_ONLY` in `ozone-site.xml` is rejected the same way as a disabled HTTP listener (`TestLocalOzoneCluster#prepareConfigurationRejectsHttpsOnlyHttpPolicyWhenS3GatewayEnabled`). Checkstyle is clean on the touched modules; unit tests above pass locally with JDK 21. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
