adoroszlai commented on code in PR #11397:
URL: https://github.com/apache/ozone/pull/11397#discussion_r4182462914
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestRootList.java:
##########
@@ -156,6 +180,91 @@ public void testListAllBucketsUnpaginatedReturnsAll()
throws Exception {
assertNull(response.getContinuationToken());
}
+ @ParameterizedTest(name = "directory={0}, buckets={1}, limit={2},
previous={3}")
+ @CsvSource({
+ // directory, total buckets, response limit, previous index, expected
names, continuation token, RPC calls
+ "false, 0, 2, -1, '', false, 1",
+ "false, 1, 2, -1, bucket-0, false, 2",
Review Comment:
Maybe it's just me, but I find `@CsvSource` to be hard to read, it's less
type-safe than e.g. `MethodSource`, and I guess it will be difficult to update
(e.g. add a new param).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
