rajeshkumarchandolu commented on code in PR #11368:
URL: https://github.com/apache/ozone/pull/11368#discussion_r4195400173


##########
hadoop-ozone/dist/src/main/smoketest/basic/links.robot:
##########
@@ -94,6 +94,14 @@ Link to non-existent bucket
     ${result} =         Execute And Ignore Error    ozone sh key list 
${target}/dangling-link
                         Should Contain              ${result}         
BUCKET_NOT_FOUND
 
+Link to non-existent source volume
+    ${missing} =        Generate Random String  5  [NUMBERS]
+    ${missingVol} =     Set Variable              ${missing}-missing-source
+                        Execute                     ozone sh bucket link 
${missingVol}/any-bucket ${target}/dangling-missing-vol

Review Comment:
   @sarvekshayr The Jira isn’t about link create failing when the source is 
missing — dangling links are allowed and create succeeds today. The issue is 
after the link exists: operations that follow the link (here key list on the 
target link bucket) could return VOLUME_NOT_FOUND when the source volume never 
existed, which is misleading.
   
   This test is meant to mirror that: create the link to a non-existent source, 
then run key list on the link and check the remapped error/message. A hardcoded 
no-such-volume/no-such-bucket is fine with me if we keep that second step; I 
used a random volume name mainly to avoid name clashes in the suite. Happy to 
simplify the first line if you prefer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to