rich7420 commented on code in PR #11429:
URL: https://github.com/apache/ozone/pull/11429#discussion_r4207713908
##########
hadoop-hdds/interface-client/pom.xml:
##########
@@ -63,41 +63,44 @@
</configuration>
</plugin>
<plugin>
- <groupId>org.xolstice.maven.plugins</groupId>
+ <groupId>io.github.ascopes</groupId>
<artifactId>protobuf-maven-plugin</artifactId>
<executions>
<execution>
<id>compile-proto-for-ratis</id>
<goals>
- <goal>compile</goal>
- <goal>test-compile</goal>
- <goal>compile-custom</goal>
- <goal>test-compile-custom</goal>
+ <goal>generate</goal>
</goals>
<configuration>
Review Comment:
Please set `<incrementalCompilation>false</incrementalCompilation>` for
`compile-proto-for-ratis` here and in `interface-server`. A second build
without `clean` skips protoc but runs the shading replacement again, producing
`org.apache.ratis.thirdparty.org.apache.ratis.thirdparty...` and failing
compilation. I reproduced this; disabling incremental compilation fixes the
failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
