jojochuang commented on code in PR #11380:
URL: https://github.com/apache/ozone/pull/11380#discussion_r4161427429


##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java:
##########
@@ -672,10 +672,12 @@ public FileChecksum getFileChecksum(String keyName, long 
length)
     if (combineMode == null) {
       return null;
     }
+    // The bucket layout is validated once in the constructor, so LookupKey is
+    // enough here; there is no InfoBucket RPC to save on this path.
     return OzoneClientUtils.getFileChecksumWithCombineMode(
-        volume, bucket, keyName,
+        volume.getName(), bucket.getName(), keyName,
         length, combineMode,
-        ozoneClient.getObjectStore().getClientProxy());
+        ozoneClient.getObjectStore().getClientProxy(), false);

Review Comment:
   if the last parameter is false, it calls lookupKey() not lookupFile.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to