chihsuan commented on code in PR #11436:
URL: https://github.com/apache/ozone/pull/11436#discussion_r4236127540
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/TestDeleteBlocksCommandHandler.java:
##########
@@ -468,6 +468,8 @@ public void
testDeleteBlockCommandHandleWhenDeleteCommandQueuesFull()
dnConf.setBlockDeleteQueueLimit(blockDeleteQueueLimit);
handler = new DeleteBlocksCommandHandler(
container, configuration, dnConf, "");
+ // Stop the worker so that handle() can fill the queue without commands
being consumed.
+ handler.stop();
Review Comment:
Just an observation: I found it interesting that `handle()` still queues
after `stop()`. 🙂 This looks fine given the production shutdown flow, but if
production later rejects commands after shutdown, we’ll need to adjust the test
setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
