smengcl commented on code in PR #11000:
URL: https://github.com/apache/ozone/pull/11000#discussion_r4236604854
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerConfiguration.java:
##########
@@ -112,9 +112,11 @@ public final class ContainerBalancerConfiguration {
private long moveReplicationTimeout = Duration.ofMinutes(50).toMillis();
@Config(key = "hdds.container.balancer.balancing.iteration.interval", type =
ConfigType.TIME,
- defaultValue = "70m", tags = {ConfigTag.BALANCER}, description =
- "The interval period between each iteration of Container Balancer.")
- private long balancingInterval = Duration.ofMinutes(70).toMillis();
+ defaultValue = "3m", tags = {ConfigTag.BALANCER}, description =
Review Comment:
Please also update the CLI help in `ContainerBalancerConfigOptions.java`,
which still advertises a 70-minute default. The Container Balancer guide in
`apache/ozone-site` needs a corresponding update to both its CLI options and
configuration tables, since omitting the option now gives a 3-minute pause.
```diff
- "The value should be positive, with a default of 70 (specify '70'
for 70 minutes).")
+ "The value should be positive, with a default of 3 (specify '3'
for 3 minutes).")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
