jojochuang commented on PR #11479: URL: https://github.com/apache/ozone/pull/11479#issuecomment-6128146477
@chungen0126 — I pushed the review feedback to a branch on @jojochuang's fork so you can pull it locally: **Branch:** `HDDS-16681-review-fixes` **Remote:** https://github.com/jojochuang/ozone/tree/HDDS-16681-review-fixes **Changes (commit `a8e74823e61`):** - Lifecycle GET uses `context.getVolumeName()` again so GetBucketLifecycle does not always call `getS3BucketDetails` when `x-amz-expected-bucket-owner` is absent. - Restored `testGetLifecycleOnlyLooksUpBucketForOwner` (with `getS3BucketDetails` stubs) and fixed the protocol-error test to expect no bucket lookup without owner header. - Updated `proto.lock` for `OMRequest.assumeS3Context` (field 8) and `OMResponse.userPrincipal` (field 162). **To apply on your branch:** ```bash git remote add jojochuang https://github.com/jojochuang/ozone.git # if needed git fetch jojochuang HDDS-16681-review-fixes git checkout HDDS-16681 git cherry-pick a8e74823e61 # or: git merge jojochuang/HDDS-16681-review-fixes ``` Note: `proto.lock` is still behind the full `.proto` for other fields (same as master); only the new HDDS-16681 fields were added here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
