shuan1026 opened a new pull request, #11503:
URL: https://github.com/apache/ozone/pull/11503

   ## What changes were proposed in this pull request?
   
   **Bug:** On first DiskBalancer init (`diskBalancer.info` absent), only 
`should.run.default` was taken from injected config; threshold, bandwidth, 
parallel thread, stop-after-disk-even, and container states were seeded via 
`new DiskBalancerConfiguration()` and persisted as Java defaults. Later 
restarts keep the wrong file; XML changes alone do not fix it.
   
   **Impact:** Operator `ozone-site.xml` tuning is ignored on new datanodes. 
Balancing may use wrong I/O limits / stop condition / movable states; 
`diskbalancer status` reports the persisted defaults with no warning.
   
   **Fix:** Seed initial `DiskBalancerInfo` from 
`conf.getObject(DiskBalancerConfiguration.class)`. Existing-file load path 
unchanged.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-16965
   
   ## How was this patch tested?
   
   - Added 
`TestDiskBalancerService#testInitialDiskBalancerInfoUsesConfiguredValues`: 
empty info dir + non-default config via `setFromObject`; asserts in-memory info 
and written YAML match configured values.
   - ci: https://github.com/shuan1026/ozone/actions/runs/38335830063


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to