jojochuang commented on code in PR #11498:
URL: https://github.com/apache/ozone/pull/11498#discussion_r4255269849
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/ozone/grpc/metrics/GrpcMetrics.java:
##########
@@ -70,15 +75,13 @@ public class GrpcMetrics implements MetricsSource {
@Metric("Number of unknown messages received")
private MutableCounterLong unknownMessagesReceived;
- @Metric("Queue time")
Review Comment:
Removing @Metric on those fields avoids double registration in the registry;
manual snapshot() on the record builder is the right single emission path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
