ChenSammi commented on code in PR #10781:
URL: https://github.com/apache/ozone/pull/10781#discussion_r4268528652
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketArgs.java:
##########
@@ -44,6 +44,11 @@ public final class OmBucketArgs extends WithMetadata
implements Auditable {
* Bucket Version flag.
*/
private final Boolean isVersionEnabled;
+ /**
Review Comment:
Can we make the isVersionEnabled deprecated on both this class and proto
definition, and OmBucketInfo too, instead of support both fields with careful
handling?
If we want to have a isVersionEnabled check(unset & missing vs
enabled&disabled, I prefer we implement a isVersionEnabled() function instead
of have two fields which one has dependency or precedence to the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
