F64116045 commented on code in PR #11534:
URL: https://github.com/apache/ozone/pull/11534#discussion_r4271763979
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestOmSCMNodesReconfiguration.java:
##########
@@ -58,11 +59,14 @@
@Timeout(300)
public class TestOmSCMNodesReconfiguration {
- private MiniOzoneHAClusterImpl cluster = null;
- private String scmServiceId;
+ private static MiniOzoneHAClusterImpl cluster;
+ private static String scmServiceId;
+ private static String scmNodesConfigKey;
Review Comment:
Nit: Now that `scmNodesConfigKey` is initialized in @BeforeAll, could we
reuse it in the test methods to avoid building the same key repeatedly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
