neils-dev commented on pull request #2473: URL: https://github.com/apache/ozone/pull/2473#issuecomment-890005861
> Thanks @neils-dev for the fix. It looks good to me. > > Thank you for testing it repeatedly via Github Actions. I find it a bit hard to follow, because: > > * Multiple fixes are present on the branch which is tested by scheduled workflow ([HDDS-5358](https://issues.apache.org/jira/browse/HDDS-5358)). > * The fix relevant for this PR is not the same commit or cherry-pick of this commit. It has extra log lines which may or may not affect the results (I guess they don't, but still, it's a difference). > > I would like to suggest the following process to make it more transparent next time: > > 1. Create a branch for the bug ([HDDS-5512](https://issues.apache.org/jira/browse/HDDS-5512) here). Apply the fix, push for full CI. > 2. From that commit start a new branch and change the workflow definition, removing unnecessary checks and adding iterations. Push for repeated tests. > 3. Once you have enough repetitions, open the PR from the fix-only branch. > > I think this setup makes it trivial to check that the same fix proposed in the PR was verified in the repeated runs. Thanks @adoroszlai for the setup to test and validate with the CI for flaky tests. I will try it out. The git actions for you mentioned (HDDS-5358) that I used was actually meant for other jira issues I was running and used to validate in the CI environ the integration tests for the issues - but it's good that you saw it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
