smengcl commented on code in PR #11557:
URL: https://github.com/apache/ozone/pull/11557#discussion_r4300569303
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java:
##########
@@ -519,12 +521,24 @@ private int processDecommissioningIndexes(
new ArrayList<>(decomIndexes), sources, availableSourceNodes,
excludedNodes, usedNodes);
if (commandsSent > 0) {
+ metrics.incrEcReconstructionDecommissionTriggeredTotal();
return commandsSent;
}
+ metrics.incrEcDecommissionReconstructionFallbackNoOpTotal();
} catch (CommandTargetOverloadedException e) {
LOG.debug("Reconstruction throttled for decommissioning container "
+ "{}, using 1-1 replication.",
container.containerID(), e);
+
metrics.incrEcDecommissionReconstructionFallbackTargetOverloadedTotal();
+ } catch (InsufficientDatanodesException e) {
+ if (replicaCount.decommissioningOnlyIndexes(true).size()
+ < decomIndexes.size()) {
+ throw e;
Review Comment:
Shall we inc the counter here as well? If so, also change
testUnderReplicationWithDecomNodesRethrowsOnPartialReconstruction accordingly.
```suggestion
if (replicaCount.decommissioningOnlyIndexes(true).size() <
decomIndexes.size()) {
metrics.incrEcReconstructionDecommissionTriggeredTotal();
throw e;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
