smengcl commented on code in PR #10829:
URL: https://github.com/apache/ozone/pull/10829#discussion_r4301867724
##########
hadoop-ozone/dev-support/checks/_build.sh:
##########
@@ -27,7 +27,7 @@ BASE_DIR="$(pwd -P)"
REPORT_DIR=${OUTPUT_DIR:-"${BASE_DIR}/target/${CHECK}"}
REPORT_FILE="$REPORT_DIR/summary.txt"
-MAVEN_OPTIONS='-V -B -DskipTests -DskipDocs --no-transfer-progress'
+MAVEN_OPTIONS='-V -B -DskipTests --no-transfer-progress'
Review Comment:
`-DskipDocs` is still passed in
`hadoop-ozone/dev-support/checks/errorprone.sh` (added after this PR was
opened) and mentioned in the Javadoc of `TestOMDirectoriesPurgeApplyPerf`.
Could you remove those too?
##########
dev-support/ci/selective_ci_checks.sh:
##########
@@ -170,6 +170,7 @@ function filter_changed_files() {
SOURCES_TRIGGERING_TESTS=(
"^.github"
+ "^design"
Review Comment:
`.github/labeler.yml` still lists `hadoop-hdds/docs/**` under
`documentation`. Please replace it with `design/**`, so changes to design doc
images also get the label (`.md` files are already covered by `**/*.md`).
##########
hadoop-ozone/dist/src/main/assemblies/ozone-src.xml:
##########
@@ -97,7 +97,6 @@
<useDefaultExcludes>true</useDefaultExcludes>
<excludes>
<exclude>**/.classpath</exclude>
- <exclude>**/.hugo_build.lock</exclude>
Review Comment:
The source tarball no longer includes the design docs. They used to be
packaged through the `hadoop-hdds` file set, and nothing here covers the new
top-level `design` directory. Please add a file set for it:
```xml
<fileSet>
<directory>design</directory>
</fileSet>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
