yandrey321 commented on code in PR #11501: URL: https://github.com/apache/ozone/pull/11501#discussion_r4304180801
########## hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/TestS3SDKWithEcParallelRead.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.s3.awssdk; + +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.hdds.scm.ScmConfigKeys; +import org.apache.hadoop.ozone.OzoneConfigKeys; + +/** Runs the S3 SDK tests with S3 Gateways that read the cells of EC keys in parallel. */ +class TestS3SDKWithEcParallelRead extends OzoneS3SDKTests { Review Comment: Done: TestS3SDKWithEcParallelRead is removed and the parallel case now runs on the existing S3 SDK cluster. OzoneS3SDKTests adds one extra gateway, outside the proxy, with ozone.client.ec.parallel.read.enabled set, and testGetMultiCellEcObjectWithReadConsistencyHeader runs each read-consistency value both serial (through the proxy) and parallel (addressing that gateway directly), asserting the parallel read pool exists only in the parallel case. Making one gateway differ needed a harness fix: S3GatewayService stores each gateway's configuration in the static OzoneConfigurationHolder, but the gateway creates its OzoneClient lazily on the first request, so every in-JVM gateway ended up with the configuration of the gateway started last. S3GatewayService now sends one request right after start so the client is created with that gateway's configuration; without it the serial cases fail because the proxy gateways also get the parallel setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
