sumitagrawl commented on PR #11187: URL: https://github.com/apache/ozone/pull/11187#issuecomment-6313802222
@rich7420 @priyeshkaratha addTransactionToDB(), removeTranactionToDB() are in sync call via ratis applyTransaction. And also onBecomeLeader() when node becomes leader is also sync call from ratis. None are parallel. So having summaryLock here and wait for time and other logic are not required as will not provide any additional help. We can revert changes in SCMDeletedBlockTransactionStatusManager.java and SCMStateMachine. We can have change only in DeletedBlockLogStateManagerImpl.java where call can be via Hadoop RPC for adding new transaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
