ChenSammi commented on PR #11696: URL: https://github.com/apache/ozone/pull/11696#issuecomment-6436371103
Thanks @smengcl , the code change itself looks good to me. But I would like to discuss what time is actually needed for this loading initial secret key operation. The current retry logic was added by [HDDS-9020](https://issues.apache.org/jira/browse/HDDS-9020), which thought that Datanode/OM start failure due to SCM not ready is a bug. Before the HDDS-9020 change, it uses "hdds.scmclient.max.retry.timeout" 10M as the max wait time, with HDDS-9020 change, it's (about 5.7 hours in total). Now it changes it to 26m. Despite the backoff interval problem, another question is if we want to keep OM/DN running, stead of stop due to timeout, what time duration is safe to guarantee that? How long it will take a SCM to startup and become ready? I don't have the clear answer for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
