amaliujia commented on code in PR #11767:
URL: https://github.com/apache/ozone/pull/11767#discussion_r4409315233
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java:
##########
@@ -348,6 +348,16 @@ public class OzoneClientConfig {
tags = ConfigTag.CLIENT)
private boolean datastreamPutBlockWithoutRaftEnabled = false;
+ @Config(key = "ozone.client.datastream.hsync.enabled",
+ defaultValue = "false",
+ type = ConfigType.BOOLEAN,
+ description = "When enabled, hsync of a Ratis data stream makes the
datanodes sync the block data and " +
+ "the PutBlock to disk before replying. Otherwise, hsync returns once
the datanodes have written them " +
+ "without sync. It takes effect only when hsync is enabled
(ozone.fs.hsync.enabled) and the PutBlock " +
+ "is committed through the data stream
(ozone.client.datastream.putblock.without.raft.enabled).",
+ tags = ConfigTag.CLIENT)
+ private boolean datastreamHsyncEnabled = false;
Review Comment:
sure I guess we only need the `sync` parameter and let the code path set it
in the hsync mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
