F64116045 commented on code in PR #11841:
URL: https://github.com/apache/ozone/pull/11841#discussion_r4414368024


##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshotManager.java:
##########
@@ -167,6 +170,49 @@ void cleanup() throws IOException {
     omSnapshotManager.invalidateCache();
   }
 
+  @ParameterizedTest
+  @ValueSource(ints = {0, 1, 2, 3, 4})
+  public void testGetActiveSnapshotWithExpectedId(int scenario) throws 
Exception {

Review Comment:
   Nit: could we give these scenarios descriptive names, such as missing, UUID 
mismatch, and deleted? That would make each case easier to follow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to