chungen0126 commented on code in PR #11479:
URL: https://github.com/apache/ozone/pull/11479#discussion_r4422793320
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -3162,7 +3172,7 @@ public Map<String, String> getObjectTagging(
throw new IOException("OzoneManager does not support S3 object tagging
API");
}
- boolean assumeS3Context = volumeName == null && resolveS3VolumeOnOm;
+ boolean assumeS3Context = volumeName == null;
Review Comment:
I think this is a bug caused by
https://github.com/apache/ozone/pull/11574#issue-5892754928 .
`assumeS3Context` shouldn't only be passed when S3_AUTH_CHECK is true. My
understanding is that as long as this feature (S3_VOLUME_CONTEXT_RESOLUTION) is
supported, null should always be passed (i.e. assumeS3Context = true). The
server side will then handle the resolution—falling back to the default s3v for
non-multitenant cases, or mapping to the corresponding tenant volume if
multitenancy is enabled.
cc @chihsuan @Russole WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
