chihsuan commented on code in PR #11871: URL: https://github.com/apache/ozone/pull/11871#discussion_r4431483039
########## .github/workflows/fork-ci-status.yaml: ########## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Fork CI status + +on: + schedule: + - cron: '*/15 * * * *' Review Comment: nit: How about offset minutes like the README [example](https://github.com/apache/infrastructure-actions/tree/main/fork-ci#usage)? GitHub [docs](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#schedule) note delays at the start of every hour. ```suggestion - cron: '7,22,37,52 * * * *' ``` ########## .github/workflows/post-commit.yml: ########## @@ -14,8 +14,6 @@ # limitations under the License. name: build-branch on: - pull_request: - types: [opened, ready_for_review, synchronize] push: paths-ignore: Review Comment: If the last push only touches `paths-ignore` files, e.g., a doc fix after review, the fork skips CI. The PR may then lose its green check. Manual dispatch works, but runs the full CI. Is that acceptable for now, or should we handle this case? ########## .github/workflows/fork-ci-status.yaml: ########## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Fork CI status + +on: + schedule: + - cron: '*/15 * * * *' + workflow_dispatch: + +permissions: + actions: read + checks: write + pull-requests: read + +concurrency: + group: fork-ci-status + cancel-in-progress: false + +jobs: + bridge: + if: github.repository_owner == 'apache' + runs-on: ubuntu-slim + timeout-minutes: 10 + steps: + - uses: apache/infrastructure-actions/fork-ci@fork-ci/v1 + with: + workflow: post-commit.yml + base-branches: master Review Comment: Should PRs to feature and release branches also get a fork check? Or is it fine to skip them for now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
