echonesis commented on code in PR #11921:
URL: https://github.com/apache/ozone/pull/11921#discussion_r4458098049
##########
hadoop-hdds/client/src/test/java/org/apache/hadoop/ozone/client/io/TestECBlockReconstructedStripeInputStream.java:
##########
@@ -561,6 +561,37 @@ void testNoErrorIfSpareLocationToRead() throws IOException
{
}
}
+ @Test
Review Comment:
Thanks for checking this, @sodonnel. I reran
`testSpareLocationReadsCurrentStripe` with JDK 21 and confirmed that it passes
with the fix and fails without it, at `Element 1048576` in the second stripe.
For easier reproduction, I pushed a [comparison
branch](https://github.com/echonesis/ozone/tree/test-HDDS-16999-without-fix).
It keeps the new tests unchanged and only removes the added comment and `seeked
= true` assignment from `closeStream()`.
I used this command on both branches:
```
mvn -pl :hdds-client clean test \
-Dtest=TestECBlockReconstructedStripeInputStream#testSpareLocationReadsCurrentStripe
\
-Dsurefire.failIfNoSpecifiedTests=true \
-DskipShade -DskipRecon
```
Could you please try the comparison branch and let me know whether it still
passes in your environment? Thanks again for taking a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
