GeorgeJahad commented on pull request #2479: URL: https://github.com/apache/ozone/pull/2479#issuecomment-895563114
I like the new bats script a lot. A couple of questions: 1. The new bats script doesn't get invoked by _hadoop-ozone/dev-support/checks/bats.sh_. Should it be? 2. When I ran it, I got these errors: ``` dev-support/ci/selective_ci_checks.sh: line 174: PR_DRAFT: unbound variable dev-support/ci/bats-support/load.bash.bash does not exist ``` which I fixed like so: ``` -load bats-support/load.bash -load bats-assert/load.bash +export PR_DRAFT=false +load bats-support/load +load bats-assert/load ``` Was I running it wrong? 3. Is it worth adding a comment like this?: ``` # This script confirms that selective_ci_checks.sh works correctly against known sha's. # To run it you must clone and then install: # https://github.com/sstephenson/bats.git # Then clone the following repos into dev-support/ci: # git clone https://github.com/ztombol/bats-assert # git clone https://github.com/ztombol/bats-support ``` Everything else looks good. I like how the 3 functions were unified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
