devmadhuu commented on code in PR #11923:
URL: https://github.com/apache/ozone/pull/11923#discussion_r4466657384
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMStoragePolicyUpgrade.java:
##########
@@ -137,17 +133,16 @@ private void preFinalizationChecks() throws Exception {
.getStoragePolicy()).isNull();
}
- /**
- * Trigger OM upgrade finalization and block until it completes. The client
id
- * must match the one {@link OMUpgradeTestUtils#waitForFinalization} polls
- * with.
- */
+ /** Trigger OM upgrade finalization and block until it completes. */
private void finalizeOMUpgrade() throws Exception {
- omClient.finalizeUpgrade("finalize-test");
+ omClient.finalizeUpgrade();
waitForFinalization(omClient);
}
private void postFinalizationChecks() throws Exception {
+
assertThat(cluster.getOzoneManager().getVersionManager().getApparentVersion())
+ .isEqualTo(OzoneManagerVersion.SOFTWARE_VERSION);
+
String created = createBucket(OzoneStoragePolicy.HOT, true);
Review Comment:
Could we extend the upgrade integration test to create a bucket through
without policy options? After finalization, it should store OM’s configured
default. Using `COLD` as the configured default would also verify that the
client does not replace it with WARM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
