smengcl opened a new pull request, #11928: URL: https://github.com/apache/ozone/pull/11928
Generated-by: Claude Code (Opus 5.5) ## What changes were proposed in this pull request? The xcompat test exercises only the legacy snapshot diff path on the current cluster, because `ozone.om.snapshot.diff.optimized.enabled` defaults to false. Old clients never read a report produced by the optimized path, including the `--ordered` (dependency ordered) report written by 2.3.0 clients. Also, the check in `read.robot` that legacy clients do not see `Report is dependency` cannot fail: clients before 2.3.0 print the reason of a snapshot diff response only for `FAILED` jobs, never for `DONE` reports. This PR: - enables the optimized snapshot diff in xcompat `docker-config`, together with `ozone.om.snapshot.force.full.diff=true`, so OM does not fall back to the legacy diff when the `ozone_rocksdb_tools` native library is not available (old OMs ignore both keys) - lets legacy clients (before 2.2.0) read the `--ordered` diff of `snapshot-1` to `snapshot-3` written by 2.3.0 clients - checks that 2.3.0 clients on a 2.3.0 cluster get `Report is dependency ordered.` for that diff, so the test fails if xcompat silently falls back to the legacy diff - removes the legacy `Report is dependency` check Follow-up of HDDS-17633. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-17702 ## How was this patch tested? Ran `xcompat/test-new.sh` (old clients 1.4.1 and 2.1.2) and `xcompat/test-old.sh` (clusters 1.4.1 and 2.1.2) locally, all passed. The OM log shows the optimized diff was used (no `Falling back to legacy diff`), the new legacy client test case ran for 1.4.1 and 2.1.2 clients on both the current and old clusters, and the positive check passed on the current cluster. CI: 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
