jojochuang commented on PR #11783: URL: https://github.com/apache/ozone/pull/11783#issuecomment-6643816917
Follow-up with links to a local reproduction + proposed fix (pushed to my fork): **Branch:** https://github.com/jojochuang/ozone/tree/HDDS-16870-pread-failed-locations-fix **Commit:** https://github.com/jojochuang/ozone/commit/e3a8f49cd63 **Diff vs PR head (`HDDS-16870`):** https://github.com/jojochuang/ozone/compare/yandrey321:HDDS-16870...jojochuang:HDDS-16870-pread-failed-locations-fix **Regression test** - [`TestECBlockInputStream#testPositionedReadFailingOnConcurrentIndexCloseDoesNotReportLocations`](https://github.com/jojochuang/ozone/blob/HDDS-16870-pread-failed-locations-fix/hadoop-hdds/client/src/test/java/org/apache/hadoop/ozone/client/io/TestECBlockInputStream.java#L900-L922) - Test stub support (closed index stream behaves like production): [`ECStreamTestUtil.TestBlockInputStream`](https://github.com/jojochuang/ozone/blob/HDDS-16870-pread-failed-locations-fix/hadoop-hdds/client/src/test/java/org/apache/hadoop/ozone/client/io/ECStreamTestUtil.java#L305-L441) **Fix** - Call site in `readPositioned`: [`ECBlockInputStream.java#L385`](https://github.com/jojochuang/ozone/blob/HDDS-16870-pread-failed-locations-fix/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStream.java#L385) - `throwPositionedReadFailures` / ignore failures when `blockStreams[index]` was closed concurrently: [`ECBlockInputStream.java#L609-L665`](https://github.com/jojochuang/ozone/blob/HDDS-16870-pread-failed-locations-fix/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStream.java#L609-L665) ```bash mvn -pl :hdds-client test \ -Dtest=TestECBlockInputStream#testPositionedReadFailingOnConcurrentIndexCloseDoesNotReportLocations \ -DskipShade -DskipRecon ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
