smengcl commented on code in PR #11523:
URL: https://github.com/apache/ozone/pull/11523#discussion_r4475628106
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -555,6 +555,10 @@ public final class OzoneConfigKeys {
"ozone.network.topology.aware.read";
public static final boolean OZONE_NETWORK_TOPOLOGY_AWARE_READ_DEFAULT = true;
+ public static final String OZONE_NETWORK_TOPOLOGY_SORT_GROUP_BY_RACK_KEY =
+ "ozone.network.topology.sort.group.by.rack";
+ public static final boolean
OZONE_NETWORK_TOPOLOGY_SORT_GROUP_BY_RACK_DEFAULT = true;
Review Comment:
It looks like `ozone-default.xml` was flipped to `false` in the second
commit, but this constant is still `true`, so the two defaults now disagree.
Should we make this `false` as well?
```suggestion
public static final boolean
OZONE_NETWORK_TOPOLOGY_SORT_GROUP_BY_RACK_DEFAULT = false;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
