peterxcli commented on PR #11086: URL: https://github.com/apache/ozone/pull/11086#issuecomment-6652640441
looked at the Ratis code: https://github.com/apache/ratis/blob/89062974c9acb0f5e5383852e5302836b2387543/ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcServerProtocolService.java#L154-L163 ```java public void onCompleted() { if (isClosed.compareAndSet(false, true)) { LOG.info("{}: Completed {}, lastRequest: {}", getId(), op, getPreviousRequestString()); requestFuture.get().thenAccept(reply -> { LOG.info("{}: Completed {}, lastReply: {}", getId(), op, reply); responseObserver.onCompleted(); }); } } ``` The `Completed INSTALL_SNAPSHOT ..., reply: ...` log is printed no matter whether the installation succeeds or fails. but looks like what @szetszwo wants in HDDS-11470 is to get rid of the misleading log message, which require ratis upstream change(eg. carry exception in rpc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
