smengcl commented on code in PR #11896:
URL: https://github.com/apache/ozone/pull/11896#discussion_r4478124015
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -317,7 +317,12 @@ protected OmMetadataManagerImpl(OzoneConfiguration conf,
File dir,
.setCreateCheckpointDirs(false)
.setEnableRocksDbMetrics(enableRocksDbMetrics)
.build();
- initializeOmTables(CacheType.PARTIAL_CACHE, false);
+ try {
+ initializeOmTables(CacheType.PARTIAL_CACHE, false);
+ } catch (IOException | RuntimeException e) {
Review Comment:
Thanks, that's cleaner. `TableInitializer` now has
`getWithDbCache(definition)`, which always uses the DB's own cache type, and
the per-table cache type overload is gone, so the volume, bucket and revoked
STS token tables can no longer pick FULL_CACHE in a snapshot or checkpoint DB.
The runtime check and the constructor cleanup it needed are removed.
`testSnapshotDbOpenLeaksNoThread` now also checks that opening a snapshot DB
and a checkpoint DB starts no `FullTableCache` cleanup thread while they are
open.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
